Skip to content

Commit

Permalink
move webOnlyScheduleFrameCallback off of window (flutter#9222)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonahwilliams committed Jun 7, 2019
1 parent 8a6bad6 commit 086b5a4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/stub_ui/lib/src/engine.dart
Expand Up @@ -120,7 +120,7 @@ void webOnlyInitializeEngine() {
domRenderer;

bool waitingForAnimation = false;
ui.window.webOnlyScheduleFrameCallback = () {
ui.webOnlyScheduleFrameCallback = () {
// We're asked to schedule a frame and call `frameHandler` when the frame
// fires.
if (!waitingForAnimation) {
Expand Down
2 changes: 1 addition & 1 deletion lib/stub_ui/lib/src/ui/test_embedding.dart
Expand Up @@ -45,7 +45,7 @@ Future<void> webOnlyInitializeTestDomRenderer({double devicePixelRatio = 3.0}) {
engine.window.debugOverrideDevicePixelRatio(devicePixelRatio);
engine.window.webOnlyDebugPhysicalSizeOverride =
Size(800 * devicePixelRatio, 600 * devicePixelRatio);
window.webOnlyScheduleFrameCallback = () {};
webOnlyScheduleFrameCallback = () {};
engine.domRenderer.debugIsInWidgetTest = true;

if (_platformInitializedFuture != null) {
Expand Down
4 changes: 2 additions & 2 deletions lib/stub_ui/lib/src/ui/window.dart
Expand Up @@ -804,8 +804,6 @@ abstract class Window {
_onLocaleChanged = callback;
}

VoidCallback webOnlyScheduleFrameCallback;

/// Requests that, at the next appropriate opportunity, the [onBeginFrame]
/// and [onDrawFrame] callbacks be invoked.
///
Expand Down Expand Up @@ -1224,6 +1222,8 @@ class IsolateNameServer {
}
}

VoidCallback webOnlyScheduleFrameCallback;

/// The [Window] singleton. This object exposes the size of the display, the
/// core scheduler API, the input event callback, the graphics drawing API, and
/// other such core services.
Expand Down

0 comments on commit 086b5a4

Please sign in to comment.