Additional invoice link #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre
requested changes
Dec 12, 2023
| @@ -99,6 +99,9 @@ module Kaui | |||
| # Link to the customer invoice (HTML, PDF, etc.) | |||
| self.customer_invoice_link = lambda { |invoice, ctx| ctx.link_to 'View customer invoice html', ctx.kaui_engine.show_html_invoice_path(invoice.invoice_id), :class => 'btn', :target => '_blank' } | |||
|
|
|||
| # Additinal Link to the customer invoice | |||
There was a problem hiding this comment.
Suggestion: Additional links on the invoice page.
| @@ -99,6 +99,9 @@ module Kaui | |||
| # Link to the customer invoice (HTML, PDF, etc.) | |||
| self.customer_invoice_link = lambda { |invoice, ctx| ctx.link_to 'View customer invoice html', ctx.kaui_engine.show_html_invoice_path(invoice.invoice_id), :class => 'btn', :target => '_blank' } | |||
|
|
|||
| # Additinal Link to the customer invoice | |||
| self.additional_invoice_links = lambda { |invoice, ctx| ctx.link_to 'Addtinal invoice link', ctx.metal_engine.bulk_invoice_adjustment_path(invoice.account_id, invoice.invoice_id), class: 'btn', target: '_self' } | |||
There was a problem hiding this comment.
The example is not very practical for users (metal_engine is proprietary). What does ctx.metal_engine.bulk_invoice_adjustment_path return? A link (maybe wrapped in a <div>)? Could you just hardcode that string?
|
@grana-equinix Did you have a chance to look at my comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds customization details with example from killbill-admin-ui