Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional invoice link #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Additional invoice link #65

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4398008
Adds customization function
grana-equinix Dec 12, 2023
5911500
Update
grana-equinix Dec 12, 2023
4c5502f
Merge branch 'killbill:master' into additional_invoice_link
grana-equinix Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CUSTOMIZATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ module Kaui
# Link to the customer invoice (HTML, PDF, etc.)
self.customer_invoice_link = lambda { |invoice, ctx| ctx.link_to 'View customer invoice html', ctx.kaui_engine.show_html_invoice_path(invoice.invoice_id), :class => 'btn', :target => '_blank' }

# Additinal Link to the customer invoice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Additional links on the invoice page.

self.additional_invoice_links = lambda { |invoice, ctx| ctx.link_to 'Addtinal invoice link', ctx.metal_engine.bulk_invoice_adjustment_path(invoice.account_id, invoice.invoice_id), class: 'btn', target: '_self' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example is not very practical for users (metal_engine is proprietary). What does ctx.metal_engine.bulk_invoice_adjustment_path return? A link (maybe wrapped in a <div>)? Could you just hardcode that string?


# How bundle keys are displayed in the account timeline
self.bundle_key_display_string = ->(bundle_key) { bundle_key }

Expand Down