Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed Subscriptions section of Kaui Guide #310

Merged
merged 14 commits into from Jan 20, 2022
Merged

Completed Subscriptions section of Kaui Guide #310

merged 14 commits into from Jan 20, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 14, 2022

I don't know if I got all of this right, so keep a sharp eye out. :-0

There's a PDF available if you want to read it that way. See page 35 - 41.

@ghost ghost requested a review from sbrossie January 18, 2022 19:36

[NOTE]
*Note:* To add an add-on to a subscription, the add-on must exist in the catalog. For information on adding an add-on to the catalog, see <<part_6_tenants_and_admin>>.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor correction: The add-on must exist in the catalog and be available in the base plan.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - see line 1003

Use one of the other two options – *Specify Policy* or *Specify a date* – to alter when this change takes effect:

* *Specify Policy*: You can select either `IMMEDIATE` or `END_OF_TERM`. For information on these two policies, see the https://docs.killbill.io/latest/userguide_subscription.html#\_subscription_alignment_rules["Subscription Alignment Rules"] section of the \_Subscription Guide_.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning that these rules can be specified in the catalog under the plan change timing section but the values specified here override the catalog values.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited - see line 1062


| Cancel end of term (no credit)
| Cancels the subscription immediately with no refund to the customer. Note that after using this option to cancel, you can still reinstate the customer (i.e., reverse the cancellation).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a typo here? Shouldn't this be Cancels the subscription at the end of the billing period?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are great! That was an error. Fixed - line 1101

. In the *New plan* field, select a different plan.
. If you need to override the price for the plan you've selected, enter the amount in the *Price Override* field.
. To accept the default policy for when this change takes effect, leave *Default policy* selected and click *Save.*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention what the default policy is? AFAIK, it is END_OF_TERM but I'll let @pierre or @sbrossie confirm.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to line 1042 (just general info) and addressed END_OF_TERM in line 1058.

Follow the steps below to update the billing cycle day (BCD) defined for a subscription. These steps assume the subscription is billed on a monthly basis.

For information on how changing the BCD affects the subscription, see the https://docs.killbill.io/latest/userguide_subscription.html#\_billing_alignment_rules["Billing Alignment Rules"] section of the \_Subscription Guide_.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Billing Alignment Rules specify whether billing occurs at the account/subscription or bundle level. Updating a subscription BCD in Kaui results in the system using the new BCD irrespective of what is specified in the billing alignment rules in the catalog. In other words, the BCD specified in Kaui overrides the catalog billing alignment rules. Might be useful to add this context here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed reference to Billing Alignment Rules. Added your info to line 118.

| To define a specific date on which the subscription begins, select this option, and choose a date from the *Date* field that appears.

|===

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below the "Add Add-on", there are other options like "Transfer Ownership" and "Pause/Resume". Are these intentionally left out?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ALL NEW Pause/Resume section below (1040). Pierre said to not document the Transfer Ownership feature for now.

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reshmabidikar - All of your comments have been addressed. Let me know if I missed anything. Thanks for catching all of that.

. In the *New plan* field, select a different plan.
. If you need to override the price for the plan you've selected, enter the amount in the *Price Override* field.
. To accept the default policy for when this change takes effect, leave *Default policy* selected and click *Save.*

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to line 1042 (just general info) and addressed END_OF_TERM in line 1058.

Use one of the other two options – *Specify Policy* or *Specify a date* – to alter when this change takes effect:

* *Specify Policy*: You can select either `IMMEDIATE` or `END_OF_TERM`. For information on these two policies, see the https://docs.killbill.io/latest/userguide_subscription.html#\_subscription_alignment_rules["Subscription Alignment Rules"] section of the \_Subscription Guide_.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited - see line 1062


| Cancel end of term (no credit)
| Cancels the subscription immediately with no refund to the customer. Note that after using this option to cancel, you can still reinstate the customer (i.e., reverse the cancellation).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are great! That was an error. Fixed - line 1101


[NOTE]
*Note:* To add an add-on to a subscription, the add-on must exist in the catalog. For information on adding an add-on to the catalog, see <<part_6_tenants_and_admin>>.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - see line 1003

Follow the steps below to update the billing cycle day (BCD) defined for a subscription. These steps assume the subscription is billed on a monthly basis.

For information on how changing the BCD affects the subscription, see the https://docs.killbill.io/latest/userguide_subscription.html#\_billing_alignment_rules["Billing Alignment Rules"] section of the \_Subscription Guide_.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed reference to Billing Alignment Rules. Added your info to line 118.

| To define a specific date on which the subscription begins, select this option, and choose a date from the *Date* field that appears.

|===

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ALL NEW Pause/Resume section below (1040). Pierre said to not document the Transfer Ownership feature for now.

Copy link
Contributor

@reshmabidikar reshmabidikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good @FlowWriter, I've found one minor new issue about URLs not rendering properly in the asciidoc file. I've added a comment related to this.

OR

You can select one of two other options: *Specify Policy* or *Specify a date*. This will override the policy defined in the catalog for the plan. (For information on this topic, see see https://docs.killbill.io/latest/userguide_subscription.html#_plan_change_timing["Plan Change Timing"] in the _Subscription Guide_.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


OR

You can select one of two other options: *Specify Policy* or *Specify a date*. This will override the policy defined in the catalog for the plan. (For information on this topic, see see https://docs.killbill.io/latest/userguide_subscription.html#_plan_change_timing["Plan Change Timing"] in the _Subscription Guide_.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: see see

@pierre
Copy link
Member

pierre commented Jan 20, 2022

Merging so we can check the rendering.

@pierre pierre merged commit 45e1975 into killbill:v3 Jan 20, 2022
@ghost ghost deleted the kaui-only-5 branch August 24, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants