close configurable's resources when config is deleted #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre
reviewed
Dec 4, 2019
| @@ -69,11 +69,13 @@ public void setDefaultConfigurable(final T defaultConfigurable) { | |||
| @Override | |||
| protected void configure(@Nullable final UUID kbTenantId) { | |||
| final String rawConfiguration = getTenantConfigurationAsString(kbTenantId); | |||
| T configurable = null; | |||
There was a problem hiding this comment.
Shouldn't PluginTenantConfigurableConfigurationHandler be updated as well (it's the key-value version of the YAML one)?
added 2 commits
December 4, 2019 12:08
sbrossie
approved these changes
Dec 4, 2019
|
|
||
| // configure tenants | ||
| mockTenantKvsCloseable(configuredTenant, ImmutableList.<String>of("CloseableTest"), nonConfiguredTenant, ImmutableList.<String>of()); | ||
| closableConfigurationHandler.configure(configuredTenant); |
There was a problem hiding this comment.
Is this line really necessary -- the method getConfigurable will call configure here ?
There was a problem hiding this comment.
- only for a new tenant (not in the
configuredTenantsset of the handler) closableConfigurationHandler.configure(configuredTenant);is the call that would be made when the framework receives a config update
sbrossie
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.