invoice: Make sure we don't swallow global lock error during invoice …

…api calls
killbill · Apr 15, 2021 · e432b0c · e432b0c
1 parent ce733ea
commit e432b0c
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/invoice/src/main/java/org/killbill/billing/invoice/api/InvoiceApiHelper.java b/invoice/src/main/java/org/killbill/billing/invoice/api/InvoiceApiHelper.java
@@ -127,8 +127,7 @@ public List<InvoiceItem> dispatchToInvoicePluginsAndInsertItems(final UUID accou
 
             return fromInvoiceItemModelDao(createdInvoiceItems);
         } catch (final LockFailedException e) {
-            log.warn("Failed to process invoice items for accountId='{}'", accountId.toString(), e);
-            return ImmutableList.<InvoiceItem>of();
+            throw new InvoiceApiException(e, ErrorCode.UNEXPECTED_ERROR, "Failed to process invoice items: failed to acquire lock");
         } finally {
             if (lock != null) {
                 lock.release();