Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission extension #1126

Closed
sbrossie opened this issue Mar 28, 2019 · 1 comment
Closed

Permission extension #1126

sbrossie opened this issue Mar 28, 2019 · 1 comment
Assignees
@pierre
Labels
enhancement

Comments

@sbrossie
Copy link
Member

Ability to extend our currently static enum of permissions -- mostly for plugins to handle additional custom permissions using the same logic we currently have.
@sbrossie
Copy link
Member Author

One option would be to extend the enum with a new EXT("", "") type in the enum. Such values would be populated on the fly by Kill Bill based on what has been defined in the DB (assuming a DB store).

The code in in SecurityApi would need to be relaxed to accept custom values.

pierre added a commit to killbill/killbill-api that referenced this issue Apr 14, 2019
@pierre
security: make SecurityApi#getCurrentUserPermissions return Set<String>
1230ae9 
See killbill/killbill#1126.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Apr 14, 2019
@pierre
util: allow for custom permissions
4fa78fb 
This fixes #1126.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Apr 14, 2019
@pierre
util: allow for custom permissions
f04cde9 
This fixes #1126.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit to killbill/killbill-api that referenced this issue Apr 14, 2019
@pierre
security: make SecurityApi#getCurrentUserPermissions return Set<String>
deeabf0 
See killbill/killbill#1126.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre mentioned this issue Apr 14, 2019
Merged
pierre added a commit that referenced this issue Apr 14, 2019
@pierre
util: allow for custom permissions
573eb8c 
This fixes #1126.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre mentioned this issue Apr 14, 2019
Merged
@pierre pierre self-assigned this Apr 18, 2019
@pierre pierre closed this as completed Apr 23, 2019
@pierre pierre mentioned this issue Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierre pierre

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pierre @sbrossie