Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KB ecosystem to use Java fluent api #1615

Closed
sbrossie opened this issue Mar 3, 2022 · 2 comments
Closed

Update KB ecosystem to use Java fluent api #1615

sbrossie opened this issue Mar 3, 2022 · 2 comments

Comments

@sbrossie
Copy link
Member

sbrossie commented Mar 3, 2022

Our code base was started prior Java fluent api, and so we embraced Guava (e.g Iterables.xxx) to perform filtering, sorting, merging operations on data structures - e.g here

We would like to replace all those with new Java syntax and ideally remove guava as a dependency:

object.stream()
                .filter(xxx)
                .***
@sbrossie
Copy link
Member Author

sbrossie commented Mar 3, 2022

In order to do this, we could work, repo by repo, and then for big repos such as killbill/killbill module by module (and make one PR per module).

xsalefter added a commit to xsalefter/killbill that referenced this issue Mar 11, 2022
This commit only affected (part of) killbill-util module. Related issue: killbill#1615
xsalefter added a commit to xsalefter/killbill that referenced this issue Mar 11, 2022
…tion API

This commit only affected (part of) killbill-util module. Related issue: killbill#1615
@xsalefter
Copy link
Contributor

xsalefter commented May 16, 2022

Additional notes:

  • Discussion and resolution about Guava's Event Bus.

  • Discussion about Guava's Cache.

  • FIXME-1615: DefaultPaginationHelper mean that class if this class refactored, it affect several modules in killbill repository. Thus, fix for this class need to handled by one dedicated PR.

  • FIXME-1615 : killbill-client-java : RequestOptions using MultiMap : Exist in killbill-profile-killbill module. This is need work on killbill-client-java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants