Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax invoicing rules around additional items received from plugins #2004

Closed
sbrossie opened this issue Apr 12, 2024 · 2 comments
Closed

Relax invoicing rules around additional items received from plugins #2004

sbrossie opened this issue Apr 12, 2024 · 2 comments
Assignees
@sbrossie @KBbitsP
Labels
enhancement INVOICE

Comments

@sbrossie
Copy link
Member

Our code currently adds some restrictions on the fields that can be modified for existing items in the system while doing an invoice run.

There is an ask to relax some of these restrictions to allow setting he following: quantity, rate, amount item_details, description.

A proposal would be to relax this for EXTERNAL_CHARGE items as there is no expectation from the system.
@shaun-forgie
Copy link

What is the usecase for this?

sbrossie added a commit that referenced this issue Apr 22, 2024
@sbrossie
invoice: Relax invoicing rules around additional items received from …
63ae35a 
…plugins. See #2004
@sbrossie sbrossie mentioned this issue Apr 23, 2024
Merged
@sbrossie sbrossie self-assigned this Apr 23, 2024
@sbrossie sbrossie reopened this Apr 30, 2024
@sbrossie
Copy link
Member Author

Re-open as fix does not work.

sbrossie added a commit that referenced this issue Apr 30, 2024
@sbrossie
invoice: Relax invoicing rules around additional items received from …
57e9b75 
…plugins. See #2004

The original fix in 63ae35a was incomplete.
sbrossie added a commit that referenced this issue May 4, 2024
@sbrossie
Merge pull request #2011 from killbill/fix-for-2004
1801cf7 
invoice: Relax invoicing rules around additional items received from plugins. See #2004
@sbrossie sbrossie closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrossie sbrossie

@KBbitsP KBbitsP

Labels
enhancement INVOICE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sbrossie @shaun-forgie @KBbitsP @reshmabidikar