Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding bulk API to cancel subscriptions #451

Closed
pierre opened this issue Dec 16, 2015 · 1 comment
Closed

Consider adding bulk API to cancel subscriptions #451

pierre opened this issue Dec 16, 2015 · 1 comment
Assignees
@pierre
Labels
ENTITLEMENT OVERDUE
Milestone
Release-0.16.1

Comments

@pierre
Copy link
Member

pierre commented Dec 16, 2015

Overdue will cancel subscriptions serially. This make the invoice changes non deterministic: repairs will appear on one or several new invoices depending on when the bus events are processed (for example, if all cancellations happen before invoice processes the first bus event, all repairs will appear on a single new invoice).
@pierre pierre mentioned this issue Dec 16, 2015
Closed
@pierre pierre added this to the Release-0.16.1 milestone Dec 16, 2015
@pierre
Copy link
Member Author

pierre commented Dec 17, 2015

Work is to introduce a new internal API (i.e. in api submodule, not in killbill-api repo) to cancel subscriptions in block. We already have support for it at the DAO level.

As part of it, we could cleanup the extra DAO APIs (keep the ones accepting a list of objects, instead of having two APIs, one for a single subscription and one for a list of subscriptions).

@pierre pierre self-assigned this Jan 11, 2016
pierre added a commit that referenced this issue Jan 11, 2016
@pierre
entitlement: remove unused parameter in BlockingStateDao#setBlockingS…
cd9625a 
…tate

Relates to #451.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Jan 12, 2016
@pierre
entitlement: send event from transaction when setting new blocking state
678083e 
Relates to #451.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Jan 12, 2016
@pierre
entitlement: set blocking states in bulk
8fde07e 
This makes sure that add-ons are blocked in the same transaction for example.

Relates to #451.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Jan 12, 2016
@pierre
overdue: cancel entitlements in bulk
d3e7896 
This fixes the entitlement portion of #451.
More work is required in subscription base.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Jan 13, 2016
@pierre
subscription: make change and cancel operations transactional
9b32f45 
When changing or canceling a subscription, make sure to cancel
associated add-ons in the same transaction.

Relates to #451.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Jan 13, 2016
@pierre
subscription: send effective events from transactions
da2f94d 
Relates to #451.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Jan 14, 2016
@pierre
entitlement: fix regression when computing effective cancellation date
92ad32b 
ClockUtil will in some cases default to clock.getUTCNow() when transforming the local date
into a date time, which can break add-ons cancellations.

This was a known issue but we re-introduced it after the recent reshuffling of the code
to support bulk cancellations.

Relates to #451.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre closed this as completed in 7b3da0e Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierre pierre

Labels
ENTITLEMENT OVERDUE
Projects
None yet
Milestone
Release-0.16.1
Development

No branches or pull requests
1 participant
@pierre