Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Payment amounts use processed values? #482

Closed
pierre opened this issue Feb 3, 2016 · 0 comments
Closed

Should Payment amounts use processed values? #482

pierre opened this issue Feb 3, 2016 · 0 comments
Labels
PAYMENT question
Milestone
Release-0.16.2

Comments

@pierre
Copy link
Member

pierre commented Feb 3, 2016

Payment#authAmount, Payment#captureAmount, etc. return the total requested auth amount, should we return the processed auth amount instead?

The individual transactions would still have the requested amounts and it would clarify the following scenario:

  • Auth: $10 requested, $10 processed
  • Capture1: $10 requested, $5 processed
  • Capture2: $5 requested, $5 processed

Payment#captureAmount is now $15.
@pierre pierre added this to the Release-0.16.2 milestone Feb 3, 2016
pierre added a commit that referenced this issue Feb 4, 2016
@pierre
payment: make amounts use processed values
d491768 
This fixes #482.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
pierre added a commit that referenced this issue Feb 4, 2016
@pierre
beatrix: fix TODO in TestInvoicePayment
e0d6549 
Relates to #482.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PAYMENT question
Projects
None yet
Milestone
Release-0.16.2
Development

No branches or pull requests
1 participant
@pierre