0.21.9 release candidate #1257
Merged
0.21.9 release candidate #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s inside our tree
…x-for-invoice-tree
This tests a scenario where we move from monthly -> annual with a pause in the middle. The test partially fails as it should regenerate nothing and instead regenerates 2 canceling items (net is $0).
See https://github.com/killbill/killbill/releases/tag/killbill-0.21.8 Signed-off-by: Kill Bill core team <contact@killbill.io>
The change introduced in beca83b#diff-6bbd5e696930ee20c12f24087244c833R234 is actually correct, i.e the recurring billing associated with an event marking cancelation or pause should be set to `NO_BILLING_PERIOD`. However, our invoicing code contains another bug where we keep adding future notifications for canceled subscriptions. Prior this change, this was not visible as the notification was set in the future but with the change from commit beca83b, the notification becomes in the past and what was previously an unused future notification now leads to infinite loops. The fix is to remove future notifications when there is nothing to invoice in the future.
…nto fix-for-invoice-tree
…_ADVANCE & IN_ARREAR)
…into work-for-release-0.21.x-0-21-9
…for-release-0.21.x-0-21-9
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.