invoice: Fix issue when transititionning a (invoice) REFUND from PEND… #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ING -> SUCCESS. See #1453 The test written for #1453 showed that we need a similar mechanism we have in place for ATTEMPT, where we support having a row into `invoice_payments` table with a `success=false` to support cases for PENDING ATTEMPT. We now, have a similar mechanism in place for REFUND with this fix, and the beatrix test was updated to reflect that upon creating the PENDING refund we now get a `INVOICE_PAYMENT_ERROR` event and later when doing the notifyPendingTransactionOfStateChangedWithPaymentControl we see the `INVOICE_ADJUSTMENT`. TODO: * The same logic is missing for CHARGEBACK * We should aggregate this code as this is realy the same logic for all 3 use cases
pierre
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ING -> SUCCESS. See #1453
The test written for #1453 showed that we need a similar mechanism we have in place for ATTEMPT,
where we support having a row into
invoice_paymentstable with asuccess=falseto support casesfor PENDING ATTEMPT.
We now, have a similar mechanism in place for REFUND with this fix, and the beatrix test was updated to reflect
that upon creating the PENDING refund we now get a
INVOICE_PAYMENT_ERRORevent and later when doing thenotifyPendingTransactionOfStateChangedWithPaymentControl we see the
INVOICE_ADJUSTMENT.TODO: