Round 1 changes for 1952 #2022
Merged
Round 1 changes for 1952 #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrossie
approved these changes
Jun 6, 2024
| @@ -521,14 +521,14 @@ public List<InvoiceItemModelDao> inTransaction(final EntitySqlDaoWrapperFactory | |||
| } | |||
|
|
|||
| @Override | |||
| public List<InvoiceModelDao> getInvoicesBySubscription(final UUID subscriptionId, final InternalTenantContext context) { | |||
| public List<InvoiceModelDao> getInvoicesBySubscription(final UUID subscriptionId, final InternalTenantContext context) { //TODO_1952 - This method is used only by tests, so passing includeTrackingIds=false. Can we delete this method? | |||
There was a problem hiding this comment.
I think deleting would be great - if not passing false is good.
| @@ -1316,7 +1316,7 @@ public InvoiceModelDao getParentDraftInvoice(final UUID parentAccountId, final I | |||
| final InvoiceSqlDao invoiceSqlDao = entitySqlDaoWrapperFactory.become(InvoiceSqlDao.class); | |||
| final InvoiceModelDao invoice = invoiceSqlDao.getParentDraftInvoice(parentAccountId.toString(), context); | |||
| if (invoice != null) { | |||
| invoiceDaoHelper.populateChildren(invoice, invoicesTags, false, entitySqlDaoWrapperFactory, context); | |||
| invoiceDaoHelper.populateChildren(invoice, invoicesTags, false, false, entitySqlDaoWrapperFactory, context); //TODO_1952 - Passing includeTrackingIds=false, revisit to confirm if this is correct | |||
There was a problem hiding this comment.
Yes, passing false is correct - this is only used internally. The rule is that if the invoice (or list of invoices) are not returned to the client (jaxrs or plugins), we can pass false.
| @@ -281,7 +285,7 @@ public List<InvoiceModelDao> getAllInvoicesByAccountFromTransaction(final Boolea | |||
| .filter(invoice -> includeVoidedInvoices || !InvoiceStatus.VOID.equals(invoice.getStatus())) | |||
| .collect(Collectors.toUnmodifiableList()); | |||
| if (includeInvoiceComponents) { | |||
| populateChildren(filtered, invoicesTags, false, entitySqlDaoWrapperFactory, context); | |||
| populateChildren(filtered, invoicesTags, false, true, entitySqlDaoWrapperFactory, context); | |||
There was a problem hiding this comment.
Good. For pass #2, this probably one option where we could optimize based on use cases, internal vs externals.
sbrossie
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round 1 changes for #1952:
I will implement the following as part of Round 2: