tests: Replace tempdir with tempfile #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tempdir crate, a dev-dependency needed for the tests, has been deprecated in favor of tempfile. This patch replaces tempdir 0.3.7 with tempfile 3.1.0. Note that this patch also removes the prefixes from the temporary directories: They are no longer required by the API, and they are not needed for the tests.
bors bot
pushed a commit
that referenced
this pull request
Jan 29, 2020
The tempdir crate, a dev-dependency needed for the tests, has been deprecated in favor of tempfile. This patch replaces tempdir 0.3.7 with tempfile 3.1.0. Note that this patch also removes the prefixes from the temporary directories: They are no longer required by the API, and they are not needed for the tests. ---- I wrote this patch for the Debian package as the deprecated tempdir crate will not be packaged for Debian. But I think it would make sense to also replace the dependency upstream.
|
(I'm afraid merges by bors are blocked on #377) |
Build failed
|
|
Unrelated, but blocking CI to pass: this clippy pass is failing |
|
Danke! :)
|
ordian
added a commit
to ordian/cargo-edit
that referenced
this pull request
Oct 3, 2020
* master: (21 commits) Fix fetch for non lowercase crate names (killercup#398) Fix all clippy warnings (killercup#422) Keep dependencies in sorted order if they were already sorted (killercup#421) refacored getting checkout name into a function. convert to file_name earlier Fix to allow any remote name to be used Replace use and suggestion of deprecated `--all` (killercup#407) Fix pkgid option descrion for `rm` command (killercup#405) Normalise windows-style paths (killercup#403) "Working with features" updated (killercup#395) release 0.6.0 (killercup#393) Add `--workspace` to cargo-upgrade and deprecate `--all` (killercup#392) Add `--package <pkgid>` to all commands (killercup#390) Fix clippy warnings and some errors on Windows (killercup#382) tests: Replace tempdir with tempfile (killercup#380) Dependency support for git branches (killercup#379) Update help output in readme file (killercup#378) bump version to 0.5.0 (killercup#376) Add a dependency that was renamed previously (killercup#351) Upgrade to reqwest 0.10 (killercup#368) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tempdir crate, a dev-dependency needed for the tests, has been
deprecated in favor of tempfile. This patch replaces tempdir 0.3.7 with
tempfile 3.1.0.
Note that this patch also removes the prefixes from the temporary
directories: They are no longer required by the API, and they are not
needed for the tests.
I wrote this patch for the Debian package as the deprecated tempdir
crate will not be packaged for Debian. But I think it would make sense
to also replace the dependency upstream.