Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --package <pkgid> to all commands #390

Merged
merged 9 commits into from Mar 19, 2020
Merged

Add --package <pkgid> to all commands #390

merged 9 commits into from Mar 19, 2020

Conversation

pwoolcoc
Copy link
Contributor

Closes #231

@ordian
Copy link
Collaborator

ordian commented Mar 19, 2020

@pwoolcoc this looks great, thank you so much!

The only thing that's is missing is unit-tests. I imagine it could involve changing a working directory to a test workspace and executing cargo add/upgrade -p <pkg>.

@pwoolcoc
Copy link
Contributor Author

@ordian sure, sorry about that, it was 1:30am when I opened this and I totally forgot 🤦

@pwoolcoc
Copy link
Contributor Author

pwoolcoc commented Mar 19, 2020

r? @ordian

Copy link
Collaborator

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm sure many people will be happy to see this feature finally implemented.

our auto-merge system is blocked on #377, so I'll have to merge it manually after the green light from CI

@ordian ordian merged commit a998f23 into killercup:master Mar 19, 2020
@pwoolcoc pwoolcoc deleted the issue-231-feature-request-cargo-add-p-in-a-workspace branch March 19, 2020 15:29
@ordian ordian mentioned this pull request Mar 19, 2020
ordian added a commit to ordian/cargo-edit that referenced this pull request Oct 3, 2020
* master: (21 commits)
  Fix fetch for non lowercase crate names (killercup#398)
  Fix all clippy warnings (killercup#422)
  Keep dependencies in sorted order if they were already sorted (killercup#421)
  refacored getting checkout name into a function.
  convert to file_name earlier
  Fix to allow any remote name to be used
  Replace use and suggestion of deprecated `--all` (killercup#407)
  Fix pkgid option descrion for `rm` command (killercup#405)
  Normalise windows-style paths (killercup#403)
  "Working with features" updated (killercup#395)
  release 0.6.0 (killercup#393)
  Add `--workspace` to cargo-upgrade and deprecate `--all` (killercup#392)
  Add `--package <pkgid>` to all commands (killercup#390)
  Fix clippy warnings and some errors on Windows (killercup#382)
  tests: Replace tempdir with tempfile (killercup#380)
  Dependency support for git branches (killercup#379)
  Update help output in readme file (killercup#378)
  bump version to 0.5.0 (killercup#376)
  Add a dependency that was renamed previously (killercup#351)
  Upgrade to reqwest 0.10 (killercup#368)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: "cargo add -p" in a workspace
2 participants