Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record time field dropdown values does not match the input required format #4548

Closed
3 tasks done
sonroyaalmerol opened this issue Jan 10, 2024 · 5 comments · Fixed by #4595
Closed
3 tasks done

Record time field dropdown values does not match the input required format #4548

sonroyaalmerol opened this issue Jan 10, 2024 · 5 comments · Fixed by #4595
Labels

Comments

@sonroyaalmerol
Copy link

Describe the issue

Whenever I manually edit a time field, the format of the time values in the dropdown does not conform with the validation regex of the input field itself. Thus, I keep having the "Please match the requested format." unless I manually change "a.m." to "AM" or "p.m." to "PM".

I already tried

Kimai version

2.8.0

How do you run Kimai?

Docker

Which PHP version are you using?

8.2

Logfile

No response

Screenshots

image

@sonroyaalmerol
Copy link
Author

Just a follow up. Probably have something to do with localization. This only happens when I'm using en_CA. I can probably set it to en as default for now until we get a fix.

image
image

@kevinpapst kevinpapst added this to the 3.0 - Planned features milestone Jan 22, 2024
@kevinpapst
Copy link
Member

kevinpapst commented Jan 22, 2024

Thanks for adding screenshots, I have the same report for some other formats (like Greek).
I'll check it soon!

The fix I see right now is to use the locale for displaying the times, but for entering times use the simpler format.

@ryan-carpenter
Copy link

Also applies to lowercase am/pm in en_AU
Screenshot_20240127_kimai-format

@kevinpapst
Copy link
Member

Will be fixed with the next release, i did a larger refactoring and you can now select two user preferences:

  • one for translations
  • one for value formats

See #4595

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please share your experience with the community and leave a testimonial to support Kimai.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
@kevinpapst kevinpapst removed this from the Planned features milestone Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants