Split user language (UI translation) from locale (formatted values) #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- calculate region codes by existing locales - skip region codes for certain locales - skip region codes for locales if settings are the same
- added new locales id, pa, sl - removed many duplicated locales
…tions and locale for formats
…ge (translation) and locale (format)
This was referenced Jan 29, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4595 +/- ##
============================================
+ Coverage 88.16% 88.17% +0.01%
- Complexity 8781 8797 +16
============================================
Files 784 785 +1
Lines 29361 29415 +54
============================================
+ Hits 25885 25936 +51
- Misses 3476 3479 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new user setting to differentiate between the language for the UI translations and the locale (for formatting money, time, numbers and dates):
It also:
User::getLocale()method, as it now returns the locale for formatting values, whileUser::getLanguage()returns the locale for translationsid,pa,sl(a lot of translations are still missing)amandpmandAMandPMTypes of changes
Checklist
composer code-check)