Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API methods to handle teams and users #1384

Merged
merged 14 commits into from
Jan 28, 2020
Merged

API methods to handle teams and users #1384

merged 14 commits into from
Jan 28, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jan 16, 2020

Description

Planned methods:

  • create team
  • update team
  • add member to team
  • remove member from team
  • grant access to customer/project
  • revoke access from customer/project
  • create user
  • update user

Fixes #1331

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst marked this pull request as ready for review January 21, 2020 23:23
@kevinpapst
Copy link
Member Author

@kbancerz this PR is ready for testing, want to jump in?

kbancerz added a commit to kbancerz/kimai-python that referenced this pull request Jan 28, 2020
Client based on the api-teams dev branch - PR #1384 - kimai/kimai#1384
@kevinpapst kevinpapst merged commit 836a530 into master Jan 28, 2020
@kevinpapst kevinpapst deleted the api-teams branch January 28, 2020 21:28
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1384 into master will decrease coverage by 0.06%.
The diff coverage is 60.97%.

@@             Coverage Diff              @@
##             master    #1384      +/-   ##
============================================
- Coverage     92.63%   92.57%   -0.07%     
- Complexity     4062     4074      +12     
============================================
  Files           384      384              
  Lines         12391    12418      +27     
============================================
+ Hits          11479    11496      +17     
- Misses          912      922      +10
Impacted Files Coverage Δ Complexity Δ
src/API/UserController.php 87.5% <ø> (-0.18%) 16 <0> (ø)
src/Command/UpdateCommand.php 60.34% <43.75%> (-4.37%) 16 <0> (+3)
src/Controller/DoctorController.php 72.56% <53.84%> (-1.48%) 38 <0> (+4)
src/Utils/ParsedownExtension.php 96.87% <91.66%> (-3.13%) 9 <5> (+5)

@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User and Team API
1 participant