Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to use only pre-defined tags #1463

Merged
merged 1 commit into from
Feb 12, 2020
Merged

added option to use only pre-defined tags #1463

merged 1 commit into from
Feb 12, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 12, 2020

Description

New configuration to choose between:

  • a multi-select dropdown for tags (tags cannot be created by the user => central management)
  • the free text-field with autocompletion as used currently (default) for tags

Fixes #1446
Fixes #835

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.8 milestone Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #1463 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1463      +/-   ##
============================================
+ Coverage     92.55%   92.58%   +0.02%     
- Complexity     4274     4278       +4     
============================================
  Files           411      412       +1     
  Lines         13238    13256      +18     
============================================
+ Hits          12253    12273      +20     
+ Misses          985      983       -2     
Impacted Files Coverage Δ Complexity Δ
src/Form/Type/TagsType.php 83.33% <0.00%> (ø) 3.00% <0.00%> (?%)

@kevinpapst
Copy link
Member Author

ping @rarvin maybe this is useful for you?

@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List already existing Tags Replace tags input
1 participant