Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoice #1693

Merged
merged 20 commits into from
May 10, 2020
Merged

Invoice #1693

merged 20 commits into from
May 10, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented May 8, 2020

Description

  • added PDF invoice template
  • improved invoice template select box translations
  • fix print stylesheet (remove border)
  • failsafe twig filter
  • command line: filter invoices by project ids
  • open "create invoice template" form in modal
  • added unique validator for invoice template name

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label May 8, 2020
@kevinpapst kevinpapst added this to the 1.10 milestone May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #1693 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1693      +/-   ##
============================================
+ Coverage     92.21%   92.23%   +0.02%     
- Complexity     4806     4817      +11     
============================================
  Files           444      444              
  Lines         14906    14935      +29     
============================================
+ Hits          13745    13775      +30     
+ Misses         1161     1160       -1     
Impacted Files Coverage Δ Complexity Δ
src/Entity/InvoiceTemplate.php 100.00% <ø> (ø) 50.00 <0.00> (ø)
src/Command/InvoiceCreateCommand.php 89.23% <100.00%> (+0.56%) 78.00 <0.00> (+4.00)
src/Form/Type/InvoiceRendererType.php 100.00% <100.00%> (ø) 9.00 <0.00> (+1.00)
...rc/Invoice/Hydrator/InvoiceItemDefaultHydrator.php 98.70% <100.00%> (ø) 13.00 <0.00> (ø)
...c/Invoice/Hydrator/InvoiceModelProjectHydrator.php 100.00% <100.00%> (ø) 9.00 <0.00> (ø)
src/Invoice/Renderer/PdfRenderer.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
src/Twig/DateExtensions.php 100.00% <100.00%> (ø) 27.00 <0.00> (+4.00)
src/Twig/Extensions.php 100.00% <100.00%> (+1.16%) 36.00 <0.00> (+2.00)
src/Utils/MPdfConverter.php 85.71% <100.00%> (+1.09%) 5.00 <4.00> (ø)

@kevinpapst kevinpapst merged commit e3749c8 into master May 10, 2020
@kevinpapst kevinpapst deleted the invoice branch May 10, 2020 14:20
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant