Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to order tables by more fields #1902

Merged
merged 1 commit into from
Aug 21, 2020
Merged

allow to order tables by more fields #1902

merged 1 commit into from
Aug 21, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Aug 20, 2020

Description

Fixes #1754

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.10 milestone Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #1902 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1902      +/-   ##
============================================
+ Coverage     93.18%   93.20%   +0.02%     
  Complexity     5287     5287              
============================================
  Files           501      501              
  Lines         16332    16332              
============================================
+ Hits          15219    15223       +4     
+ Misses         1113     1109       -4     
Impacted Files Coverage Δ Complexity Δ
src/Repository/Query/ActivityQuery.php 100.00% <ø> (ø) 13.00 <0.00> (ø)
src/Repository/Query/CustomerQuery.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/Repository/Query/ProjectQuery.php 100.00% <ø> (ø) 17.00 <0.00> (ø)
src/Repository/TimesheetRepository.php 92.00% <0.00%> (-0.20%) 127.00% <0.00%> (ø%)
src/Controller/ProjectController.php 91.47% <0.00%> (+2.24%) 55.00% <0.00%> (ø%)

@kevinpapst kevinpapst merged commit e6d01f2 into master Aug 21, 2020
@kevinpapst kevinpapst deleted the order-by branch August 21, 2020 08:49
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort feature for columns not in the default view
1 participant