Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link entities to invoices #2995

Closed
wants to merge 2 commits into from
Closed

link entities to invoices #2995

wants to merge 2 commits into from

Conversation

Conni2461
Copy link

@Conni2461 Conni2461 commented Dec 6, 2021 •
edited

Description

Continuation of #2414 (did rebase it) based on this discussion: #2630

Not sure if thats the intended way

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

kevinpapst
kevinpapst requested changes Dec 6, 2021
View reviewed changes
src/Invoice/InvoiceItemInterface.php Outdated Show resolved Hide resolved
src/Invoice/InvoiceItemRepositoryInterface.php Outdated Show resolved Hide resolved
src/Invoice/InvoiceItemRepositoryInterface.php Outdated Show resolved Hide resolved
src/Repository/TimesheetRepository.php Outdated Show resolved Hide resolved
src/Repository/TimesheetInvoiceItemRepository.php Outdated Show resolved Hide resolved
@Conni2461 Conni2461 force-pushed the entity-to-invoice branch 3 times, most recently from 6beae07 to 9154dc9 Compare December 6, 2021 14:16
@Conni2461
Copy link
Author

@kevinpapst This should be better now. I did find a couple of things that didn't work yet.

@kevinpapst kevinpapst changed the base branch from master to entity-to-invoice December 13, 2021 23:14
@kevinpapst kevinpapst changed the base branch from entity-to-invoice to master December 13, 2021 23:14
@kevinpapst kevinpapst modified the milestone: 1.17 Dec 14, 2021
@Conni2461 Conni2461 marked this pull request as ready for review January 2, 2022 12:03
@kevinpapst
Copy link
Member

I am working on a huge refactoring of this one, including linking timesheets to multiple invoices (think canceled invoices) and a generation of a "Timesheet PDF" to provide to the customer.
So please be patient, you'll get a notification once I am done with it.

@kevinpapst kevinpapst mentioned this pull request Jan 20, 2022
Closed
3 tasks
@kevinpapst
Copy link
Member

kevinpapst commented Jan 20, 2022 •
edited

As written before, this PR is replaced by #3080
I already closed #2995
If you need this feature, please test #3080 and add changes if you need them. There is no receiveByInvoice() method right now as I don't have a use-case.
Other related changes were merged in #3079

Big thanks for spending the time to improve Kimai. Sorry that this PR did not make it, because I changed my mind during the work and sorry for the too long waiting period.

We can continue to talk in #2080 @Conni2461

@kevinpapst kevinpapst closed this Jan 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinpapst kevinpapst Awaiting requested review from kevinpapst

Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Conni2461 @kevinpapst