Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better invoices #3079

Merged
merged 5 commits into from Jan 20, 2022
Merged

Better invoices #3079

merged 5 commits into from Jan 20, 2022

Conversation

kevinpapst
Copy link
Member

Description

  • added model to InvoiceCreatedEvent
  • allow to switch formatter locale

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #3079 (b9e9b45) into master (fd4cbb4) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

@@             Coverage Diff              @@
##             master    #3079      +/-   ##
============================================
- Coverage     92.09%   92.08%   -0.02%     
- Complexity     7961     7966       +5     
============================================
  Files           697      697              
  Lines         24369    24384      +15     
============================================
+ Hits          22443    22454      +11     
- Misses         1926     1930       +4     
Impacted Files Coverage Δ
src/Invoice/DefaultInvoiceFormatter.php 78.57% <79.16%> (-21.43%) ⬇️
src/Command/InvoiceCreateCommand.php 88.59% <80.00%> (+0.04%) ⬆️
src/Event/InvoiceCreatedEvent.php 100.00% <100.00%> (ø)
src/Invoice/ServiceInvoice.php 83.75% <100.00%> (ø)
src/EventSubscriber/Actions/InvoiceSubscriber.php 85.71% <0.00%> (+9.52%) ⬆️

@kevinpapst kevinpapst marked this pull request as ready for review January 20, 2022 17:30
@kevinpapst kevinpapst merged commit 49bb998 into master Jan 20, 2022
@kevinpapst kevinpapst deleted the better-invoices branch January 20, 2022 17:41
@kevinpapst kevinpapst mentioned this pull request Jan 20, 2022
6 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

1 participant