Remove blueprints for view and view-test #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are removed in ember-cli as of 2.4.3 ember-cli/ember-cli#5607 And having them in ember-cli-coffeescript gives errors if using a never version of ember-cli in the same project ``` Cannot find module 'ember-cli/blueprints/view' Error: Cannot find module 'ember-cli/blueprints/view' at Function.Module._resolveFilename (module.js:339:15) at Function.Module._load (module.js:290:25) at Module.require (module.js:367:17) at require (internal/module.js:20:19) at Object.<anonymous> (/Users/mriska/work/test3/node_modules/ember-cli-coffeescript/blueprints/view/index.js:1:80) ```
|
This isn't mergeable now because of some other changes, but I will make sure I merge it in manually before making another release. Thank you! |
|
The view-blueprints are actually still there, but they are moved to Thank you again very much for taking the time to make this PR, but I am going to close it now. Hopefully this makes sense. |
|
No problem, thanks for fixing the issue when running them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are removed in ember-cli as of 2.4.3 ember-cli/ember-cli#5607
And having them in ember-cli-coffeescript gives errors if using a never version of ember-cli in the same project