Removing view blueprint #5607
Removing view blueprint #5607
Conversation
|
Agreed. |
jasonmit
force-pushed
the
remove-view-blueprint
branch
11 times, most recently
from
fd9181c
to
c4c053d
Compare
|
@homu r+ |
|
📌 Commit c4c053d has been approved by |
Removing view blueprint Since ember-cli now targets 2.x, which doesn't expose `Ember.View`, we should likely remove it and instead move the blueprint to the `ember-legacy-views` addon. Related: http://discuss.emberjs.com/t/can-not-generate-a-view-for-the-index-route/10131
|
💔 Test failed - status |
jasonmit
force-pushed
the
remove-view-blueprint
branch
from
c4c053d
to
e3378bf
Compare
|
@stefanpenner tests should now be passing, two required trailing line breaks trolled me.. |
jasonmit
force-pushed
the
remove-view-blueprint
branch
from
e3378bf
to
3984f7f
Compare
|
@homu r+ |
|
📌 Commit 3984f7f has been approved by |
Removing view blueprint Since ember-cli now targets 2.x, which doesn't expose `Ember.View`, we should likely remove it and instead move the blueprint to the `ember-legacy-views` addon. Related: http://discuss.emberjs.com/t/can-not-generate-a-view-for-the-index-route/10131
|
☀️ Test successful - status |
|
In the future we may wish to at least leave the de-generator intact for this kind of thing. |
|
The blueprints were moved into the legacy view addon but it looks like that was never versioned. |
|
If we do a new release of ember-legacy-views then a new |
|
@stefanpenner @jasonmit ...so is ember-cli 2.4.x not ember 1.13 friendly anymore ? What is the last version ember 1.13 devs can use w/out conflict ? |
|
In lock step with Ember, but I see no reason why it wouldn't work with 1.13. If you need the blueprints you can continue to pull them in through the legacy view addon (assuming that was versioned). |
|
Or just make the files by hand... |
They are removed in ember-cli as of 2.4.3 ember-cli/ember-cli#5607 And having them in ember-cli-coffeescript gives errors if using a never version of ember-cli in the same project ``` Cannot find module 'ember-cli/blueprints/view' Error: Cannot find module 'ember-cli/blueprints/view' at Function.Module._resolveFilename (module.js:339:15) at Function.Module._load (module.js:290:25) at Module.require (module.js:367:17) at require (internal/module.js:20:19) at Object.<anonymous> (/Users/mriska/work/test3/node_modules/ember-cli-coffeescript/blueprints/view/index.js:1:80) ```
Since ember-cli now targets 2.x, which doesn't expose
Ember.View, we should likely remove it and instead move the blueprint to theember-legacy-viewsaddon.Related: http://discuss.emberjs.com/t/can-not-generate-a-view-for-the-index-route/10131