html escapting consistent with the wrapper tag: <tt> or <pre> #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avodonosov
changed the title
avodonosov
commented
Oct 24, 2022
| @@ -283,9 +283,13 @@ | |||
| (mapcar color-formatter scan) | |||
| (funcall (coloring-type-formatter-after-hook coloring-type-object))))) | |||
|
|
|||
| (defun encoder-fn (encoder) | |||
| (or (find-symbol (princ-to-string encoder) :html-encode) | |||
| (error "Unable to find encoder function ~A in the html-encode package" encoder))) | |||
There was a problem hiding this comment.
Signalling the error here is easier to debug than if we allow NIL to be returned and fail later at (funcall encoder-fn token)
|
Thanks for the patch, sorry for delay in merging. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6