-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 #360
Release 1.0.0 #360
Conversation
We can also not deprecate the old style forms yet and simply first update all documentation before adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what happened with Python 3.7 in Travis. Maybe something at the Travis end?
It's probably some download step failing. I'll restart the build.
|
Hmm, I typed a review here, I thought, but now I don't see it; unfamiliarity with working under Windows... Meanwhile, I'm starting to look into adapting the examples to use the new-style forms, both to familiarize myself and to facilitate the step to 1.0.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Following the exercise of rolling out the new-style forms in #362, I'm very happy with them. I think they're clearer and easier to use in almost all cases and worse in none.
The skfem.helpers
module pretty well accomplishes my wished-for distinction between physical and numerical indices. I think it also looks sufficiently flexible to be able to expand to cope with future requirements, as hard as they are to foresee, of course.
I added I wanted to simplify what gets passed to @gdmcbain Do you see any obvious downsides to this? It should be easy to fix the examples by writing |
Yes, I see. I wonder whether we can just use |
I'm not sure how it'd go because we have to take two parameters for different |
Unless |
Hmm, yes, I see, or if projecting between bases, e.g. between overlapping meshes. I suppose it must happen that there can be coefficients (like thermal conductivity, whatever) on each side. I mean in the abstract a bilinear form might look like (something with test functions including operators and coefficients, something with trial functions including operators and coefficients) and the two bases in general (except in the strict Galerkin case) differ. How is that handled at the moment? I think I've only had to put coefficients on the side of the test functions, as in |
Now fixes #326 . I needed that in a research problem. |
Decided to remove the deprecation warning from In future we should make a more thorough plan for handling DOF numbering and "named boundaries". Hopefully in 2.0.0. |
I'd like to proceed with 1.0.0 release even if the documentation is still lacking behind a bit, i.e. still advocating the use of some older features from which improved versions are available. We can then begin fixing those but I think there is no hurry.
Is there anything you'd like us to address before that @gdmcbain?
I think we could now consider adding
DeprecationWarning
to the old style forms. What do you think?I have now successfully written numerical examples to one unpublished scientific article using the new style forms and are pretty happy with them.
Edit: Fixes #326 . Fixes #194 .