Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #360

Merged
merged 20 commits into from
Apr 22, 2020
Merged

Release 1.0.0 #360

merged 20 commits into from
Apr 22, 2020

Conversation

kinnala
Copy link
Owner

@kinnala kinnala commented Apr 5, 2020

I'd like to proceed with 1.0.0 release even if the documentation is still lacking behind a bit, i.e. still advocating the use of some older features from which improved versions are available. We can then begin fixing those but I think there is no hurry.

Is there anything you'd like us to address before that @gdmcbain?

I think we could now consider adding DeprecationWarning to the old style forms. What do you think?

I have now successfully written numerical examples to one unpublished scientific article using the new style forms and are pretty happy with them.

Edit: Fixes #326 . Fixes #194 .

@kinnala kinnala requested a review from gdmcbain April 5, 2020 11:15
@kinnala
Copy link
Owner Author

kinnala commented Apr 5, 2020

We can also not deprecate the old style forms yet and simply first update all documentation before adding DeprecationWarning.

Copy link
Contributor

@gdmcbain gdmcbain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what happened with Python 3.7 in Travis. Maybe something at the Travis end?

@kinnala
Copy link
Owner Author

kinnala commented Apr 6, 2020 via email

@gdmcbain
Copy link
Contributor

gdmcbain commented Apr 7, 2020

Hmm, I typed a review here, I thought, but now I don't see it; unfamiliarity with working under Windows...

Meanwhile, I'm starting to look into adapting the examples to use the new-style forms, both to familiarize myself and to facilitate the step to 1.0.0.

@gdmcbain gdmcbain mentioned this pull request Apr 7, 2020
Copy link
Contributor

@gdmcbain gdmcbain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Following the exercise of rolling out the new-style forms in #362, I'm very happy with them. I think they're clearer and easier to use in almost all cases and worse in none.

The skfem.helpers module pretty well accomplishes my wished-for distinction between physical and numerical indices. I think it also looks sufficiently flexible to be able to expand to cope with future requirements, as hard as they are to foresee, of course.

@kinnala
Copy link
Owner Author

kinnala commented Apr 8, 2020

I added DeprecationWarning to this implicit casting procedure: 5a7a956 .

I wanted to simplify what gets passed to asm(..., w=w) as w. Previously it could be a bunch of different things which I found, at times, very confusing.

@gdmcbain Do you see any obvious downsides to this? It should be easy to fix the examples by writing w as {'w': w} or similar. The idea is basically to force the user to give a name to the field which also makes scenarios where multiple prescribed fields are needed more clear.

@gdmcbain
Copy link
Contributor

gdmcbain commented Apr 8, 2020

Yes, I see. I wonder whether we can just use **kwargs somehow.

@kinnala
Copy link
Owner Author

kinnala commented Apr 8, 2020

I'm not sure how it'd go because we have to take two parameters for different Basis objects so that one can have different Basis for the solution and the test function (e.g. various Petrov-Galerkin methods).

@kinnala
Copy link
Owner Author

kinnala commented Apr 8, 2020

Unless Basis and DiscreteField were interchangeable somehow. Let me look into it cause it kind of makes sense.

@gdmcbain
Copy link
Contributor

gdmcbain commented Apr 9, 2020

I'm not sure how it'd go because we have to take two parameters for different Basis objects so that one can have different Basis for the solution and the test function (e.g. various Petrov-Galerkin methods).

Hmm, yes, I see, or if projecting between bases, e.g. between overlapping meshes. I suppose it must happen that there can be coefficients (like thermal conductivity, whatever) on each side. I mean in the abstract a bilinear form might look like (something with test functions including operators and coefficients, something with trial functions including operators and coefficients) and the two bases in general (except in the strict Galerkin case) differ. How is that handled at the moment? I think I've only had to put coefficients on the side of the test functions, as in dot(grad(v), k * grad(u)) for thermal conduction with nonuniform thermal conductivity k.

@kinnala
Copy link
Owner Author

kinnala commented Apr 20, 2020

Now fixes #326 . I needed that in a research problem.

@kinnala
Copy link
Owner Author

kinnala commented Apr 21, 2020

Decided to remove the deprecation warning from Basis.get_dofs because it was heavily used and currently easy to support.

In future we should make a more thorough plan for handling DOF numbering and "named boundaries". Hopefully in 2.0.0.

@kinnala kinnala merged commit f8dc464 into master Apr 22, 2020
@kinnala kinnala deleted the release-100 branch August 7, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specify quadrature Roadmap to 1.0.0
2 participants