Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kwargs in asm for additional fields #364

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Use kwargs in asm for additional fields #364

merged 3 commits into from
Apr 9, 2020

Conversation

kinnala
Copy link
Owner

@kinnala kinnala commented Apr 9, 2020

As proposed in #360 (comment) .

After all it seemed to work fine. So the principle is now that

y = basis.interpolate(x)  # type: DiscreteField

and this gets passed to asm as keyword arguments:

asm(bilinf, basis, test=y)

This assumes e.g.

@BilinearForm
def bilinf(u, v, w):
    return u * v * w.test

Makes sense?

@kinnala kinnala requested a review from gdmcbain April 9, 2020 11:28
@kinnala
Copy link
Owner Author

kinnala commented Apr 9, 2020

I'll add some additional tests for confirming that it works with multiple fields later today.

@kinnala kinnala merged commit a73a3af into master Apr 9, 2020
@kinnala kinnala deleted the kwargs-in-asm branch August 7, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant