IMAGING-285 RationalNumber to support unsigned int format #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Line endings are now Linux style, which reduces the code differences substantially. |
|
To the best of my knowledge, this pull request is now ready for review. I was lucky in that the existing JUnit test cases covered most of what I needed to test, in particular the reading and writing of TIFF tags. Somebody did a nice job on TiffReadWriteTagsTest in the past. |
kinow
reviewed
Sep 4, 2021
There was a problem hiding this comment.
@gwlucastrig closing as we have a PR against apache/commons-imaging here: apache#164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address issue IMAGING-285 from the JIRA tracker.
Additional unit tests have been added to exercise the TIFF unsigned-integer variation for RasterNumber.
As I updated TiffReadWriteTagsTest for the new feature, I also modified the TiffReader method calls so that they do not use the HashMap params logic that is being retired in future releases. The API used is compatible with the current Imaging version, but will also work in the upcoming Alpha 3 without modification.
I just looked at the code differences... Sorry about the whitespace changes. I have no idea how that happened. I can see if I can put them back.