Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public get functions for basicAuth, basicAuthUser, basicAuthPassword #20

Merged
merged 3 commits into from
Dec 22, 2017
Merged

Add public get functions for basicAuth, basicAuthUser, basicAuthPassword #20

merged 3 commits into from
Dec 22, 2017

Conversation

dinh-van-tran
Copy link

@dinh-van-tran dinh-van-tran mentioned this pull request Dec 6, 2017
Merged
trung-doan
trung-doan reviewed Dec 6, 2017
View reviewed changes
app.go Outdated
@@ -111,6 +111,21 @@ func (app *App) SetBasicAuth(user, password string) {
app.basicAuthPassword = password
}

// IsBasicAuth indicate authentication is basic or not
func (app *App) IsBasicAuth() bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tranvan538
I think the function name is should be HasBasicAuth

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will change it.

@cy-kaneko cy-kaneko merged commit 021bd2f into kintone-labs:master Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung-doan trung-doan trung-doan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dinh-van-tran @trung-doan @cy-kaneko