This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
feat: validate contents.zip on Node API #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koba04
force-pushed
the
validation-on-node-api
branch
from
7d21fcb
to
ade187a
Compare
koba04
commented
Apr 16, 2018
src/zip.js
Outdated
| function validateManifest(entries, manifestJson, manifestPath) { | ||
| const manifestPrefix = path.dirname(manifestPath); | ||
| const getEntryKey = filePath => | ||
| path.join(manifestPrefix, filePath).replace(new RegExp(`\\${path.sep}`, 'g'), '/'); |
koba04
force-pushed
the
validation-on-node-api
branch
from
ade187a
to
73f4398
Compare
|
@teppeis |
|
@koba04 Thank you for awesome work for Windows! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95.
I reused the validation for Browsers, which validates a buffer of contents.zip,
so it doesn't depend on any local environments like paths.