Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-packer): move browserify-sign to pnpm overrides #2542

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

hung-cybo
Copy link
Contributor

Why

browserify-sign is added to plugin-packer as devDependencies. But, we don't use it directly.

What

  • Remove the devDependencies browserify-sign
  • Add it to pnpm.overrides property.

How to test

pnpm audit

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@hung-cybo hung-cybo requested review from a team and tasshi-me and removed request for a team February 1, 2024 02:39
@github-actions github-actions bot added the pkg: plugin-packer @kintone/plugin-packer label Feb 1, 2024
@tasshi-me tasshi-me merged commit 54d80b4 into master Feb 7, 2024
9 checks passed
@tasshi-me tasshi-me deleted the chore/move-browserify-sign-to-pnpm-overrides branch February 7, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: plugin-packer @kintone/plugin-packer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants