Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add skipLibCheck into some tsconfig.json #403

Closed
wants to merge 1 commit into from
Closed

chore: add skipLibCheck into some tsconfig.json #403

wants to merge 1 commit into from

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Sep 8, 2020 •
edited
Loading

⚠️ If #402 is merged, this should be closed.

Why

To avoid an error of @types/puppeteer. DefinitelyTyped/DefinitelyTyped#24419
Errors occur in #401.

What

skipLibCheck compiler option is added into tsconfig.json.
https://www.typescriptlang.org/docs/handbook/compiler-options.html#compiler-options

How to test

yarn lint & yarn test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@shisama shisama mentioned this pull request Sep 8, 2020
Merged
4 tasks
@shisama
Copy link
Contributor Author

shisama commented Sep 9, 2020

This closes because #402 is better.

@shisama shisama closed this Sep 9, 2020
@tasshi-me tasshi-me deleted the ts-compilerOptions-skipLibCheck branch February 4, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shisama