Flake8 maintenance: tests/test_api.py (#558)

- Add tests/__init__.py
- Remove unused sys import
- Reorganize library and 3rd-party imports
- Remove unused fnmatch
- Convert path lambdas to functions
- Change 'l' to 'las'

tests/test_api.py

@@ -1,32 +1,35 @@
-import os, sys
-
-sys.path.insert(0, os.path.dirname(os.path.dirname(__file__)))
-
-import fnmatch
+import os
 
 import numpy as np
 import pytest
 
+import logging
+
 import lasio
 import lasio.examples
-from lasio import read, las
 
-import logging
 
 logger = logging.getLogger(__name__)
 
 test_dir = os.path.dirname(__file__)
 
-egfn = lambda fn: os.path.join(os.path.dirname(__file__), "examples", fn)
-stegfn = lambda vers, fn: os.path.join(os.path.dirname(__file__), "examples", vers, fn)
+
+def egfn(fn):
+    # egfn = lambda fn: os.path.join(os.path.dirname(__file__), "examples", fn)
+    return os.path.join(test_dir, "examples", fn)
+
+
+def stegfn(vers, fn):
+    # stegfn = lambda vers, fn: os.path.join(os.path.dirname(__file__), "examples", vers, fn)
+    return os.path.join(test_dir, "examples", vers, fn)
 
 
 def test_version():
     assert "." in lasio.__version__
 
 
 def test_keys_curve_mnemonics():
-    l = lasio.read(egfn("sample.las"))
+    las = lasio.read(egfn("sample.las"))
     # DEPT.M                      :  1  DEPTH
     # DT  .US/M               :  2  SONIC TRANSIT TIME
     # RHOB.K/M3                   :  3  BULK DENSITY
@@ -35,37 +38,37 @@ def test_keys_curve_mnemonics():
     # SFLA.OHMM                   :  6  SHALLOW RESISTIVITY
     # ILM .OHMM                   :  7  MEDIUM RESISTIVITY
     # ILD .OHMM                   :  8  DEEP RESISTIVITY
-    assert l.keys() == ["DEPT", "DT", "RHOB", "NPHI", "SFLU", "SFLA", "ILM", "ILD"]
+    assert las.keys() == ["DEPT", "DT", "RHOB", "NPHI", "SFLU", "SFLA", "ILM", "ILD"]
 
 
 def test_LASFile_getitem():
-    l = lasio.read(egfn("sample.las"))
-    assert np.all(l["DT"] == [123.45, 123.45, 123.45])
+    las = lasio.read(egfn("sample.las"))
+    assert np.all(las["DT"] == [123.45, 123.45, 123.45])
 
 
 def test_LASFile_getitem_int():
-    l = lasio.read(egfn("sample.las"))
-    assert np.all(l[1] == [123.45, 123.45, 123.45])
+    las = lasio.read(egfn("sample.las"))
+    assert np.all(las[1] == [123.45, 123.45, 123.45])
 
 
 def test_LASFile_getitem_int_negative():
-    l = lasio.read(egfn("sample.las"))
-    assert np.all(l[-2] == [110.2, 110.2, 110.2])
+    las = lasio.read(egfn("sample.las"))
+    assert np.all(las[-2] == [110.2, 110.2, 110.2])
 
 
 def test_data_array_slice():
-    l = lasio.read(egfn("sample.las"))
-    assert np.all(l[1] == l.data[:, 1])
+    las = lasio.read(egfn("sample.las"))
+    assert np.all(las[1] == las.data[:, 1])
 
 
 def test_curves_attribute():
-    l = lasio.read(egfn("sample.las"))
-    assert isinstance(l.curves[1], las.CurveItem)
+    las = lasio.read(egfn("sample.las"))
+    assert isinstance(las.curves[1], lasio.las.CurveItem)
 
 
 def test_get_curves_method():
-    l = lasio.read(egfn("sample.las"))
-    assert l.get_curve("DT") == l.curves[1]
+    las = lasio.read(egfn("sample.las"))
+    assert las.get_curve("DT") == las.curves[1]
 
 
 def test_missing_lasfile_mnemonic():
@@ -91,16 +94,17 @@ def test_data_attr():
     # the .all() method assumes these are numpy ndarrays; that should be the case.
     assert (las.data == np.asarray([[1, 4, 7], [2, 5, 8], [3, 6, 9]])).all()
 
+
 def test_update_curve():
     las = lasio.examples.open("sample.las")
     las["NPHI"] = las["NPHI"] * 100
     assert "NPHI" in las.keys()
-    assert not "NPHI:1" in las.keys()
-    assert not "NPHI:2" in las.keys()
+    assert "NPHI:1" not in las.keys()
+    assert "NPHI:2" not in las.keys()
+
 
 def test_replace_curve():
     las = lasio.examples.open("sample.las")
     las["NPHI"] = lasio.CurveItem("NPHI", "%", "Porosity", data=(las["NPHI"] * 100))
     assert las.keys() == ["DEPT", "DT", "RHOB", "NPHI", "SFLU", "SFLA", "ILM", "ILD"]
     assert (las["NPHI"] == [45, 45, 45]).all()
-