Error if no charset encoding in response headers

[ae3e]

hi,

I tried to read a las file from a url in Jupyter.
In the response headers, the content-type is only text/plain. There's no charset.

Then I got the following error :

/opt/conda/lib/python3.6/site-packages/lasio/reader.py in open_file(file_ref, **encoding_kwargs)
     79                 response = urllib.request.urlopen(file_ref)
     80                 encoding = response.headers.get_content_charset()
---> 81                 file_ref = StringIO(response.read().decode(encoding))
     82                 logger.debug('Retrieved data decoded via {}'.format(encoding))
     83         elif len(lines) > 1: # it's LAS data as a string.

TypeError: decode() argument 1 must be str, not None

Could it be possible to use the define enconding like this :

lasio.read('http://myserver/myfile.las',encoding='windows-1252')

[kinverarity1]

Could you post a code sample with a URL that is producing the error for you? I am not getting any errors using Python 3.6:

Python 3.6.3 |Anaconda, Inc.| (default, Nov  8 2017, 15:12:41) [MSC v.1900 32 bit (Intel)]
Type 'copyright', 'credits' or 'license' for more information
IPython 6.2.1 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import lasio

In [2]: lasio.__version__
Out[2]: '0.22'

In [3]: !git log --oneline -n 3
2911da1 (HEAD, tag: v0.22) v0.22
1d36ae3 Merge pull request #249 from krzysztof-slowinski/master
fdaccb5 Merge pull request #252 from euclidity/master

In [4]: l = lasio.read('https://raw.githubusercontent.com/kinverarity1/lasio/master/tests/examples/2.0/sample_2.0.las')

Thanks for the report!

[ae3e]

Unfortunatly, it is a URL on my company's network so I can't give you a code sample with a URL. But, when I request both URLs with Postman, I can see a difference in the response headers which could explain the error :

Your file :

My file :

[kinverarity1]

Thanks! I'll reproduce that with a local server.

[ae3e]

To solve my problem, I replaced the line

https://github.com/kinverarity1/lasio/blob/master/lasio/reader.py#L80

with the following code :

if response.headers.get_content_charset() is None:
  if 'encoding' in encoding_kwargs:
    encoding=encoding_kwargs['encoding']
  else :
    encoding='utf-8'
else:
  encoding = response.headers.get_content_charset()

Tell me if you want a PR

[kinverarity1]

Looks good, yes a PR would be great, I will merge from there Thanks