Fix deprecation warnings reported in test runs #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test_read.py::test_missing_a_section DeprecationWarning: use `array.size` > 0` to check that an array is not empty. In this test we check that the array is empty, so `not array.size > 0`. - las/las_version.py DeprecationWarning: invalid escape sequence \d The solution is to use raw strings for regexs: r"\d" instead of "\d".
kinverarity1
approved these changes
May 12, 2020
|
Thank you for addressing these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecationWarning: use
array.size > 0to check that an array isnot empty. In this test we check that the array is empty, so
not array.size > 0.DeprecationWarning: invalid escape sequence \d
The solution is to use raw strings for regexs: r"\d" instead of "\d".
Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.
Thank you,
DC