Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge request to gh-ci-changes-1 branch: Change continuous integration to make a lasio wheel #400

Merged
merged 2 commits into from Sep 14, 2020

Conversation

dcslagel
Copy link
Collaborator

@dcslagel dcslagel commented Sep 14, 2020

Description:

Update github ci pip commands to use wheel

- Add setuptools and wheel to `pip install --update`
- Remove '--editable' from github ci pip install cmd

This causes lasio to be packaged as a wheel package.  Then the wheel
file is installed and tested.  Before we were running the tests on the
editable clone of the lasio repo.

Tests

Tag push:
https://github.com/dcslagel/lasio/actions/runs/254618661

...
Created wheel for lasio: filename=lasio-0.91-py3-none-any.whl
...
Installing collected packages:...lasio-0.91...

Regular branch push:
https://github.com/dcslagel/lasio/actions/runs/254606703

...
Created wheel for lasio: filename=lasio-0.1.dev1+g4494276-py3-none-any.whl
...
Installing collected packages:..lasio-0.1.dev1+g4494276...
Notes:

Because the GitHub-Actions repo is created with --no-tags the Wheel is NOT built with the previous tag. Instead, it uses 0.1 as a default. However, the commit number 4494276b is the actual commit of the branch head, which is good.

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.

Thank you,
DC

- Add setuptools and wheel to `pip install --update`
- Remove '--editable' from github ci pip install cmd
- Add setuptools and wheel to `pip install --update`
- Remove '--editable' from github ci pip install cmd

This causes lasio to be packaged as a wheel package.  Then the wheel
file is installed and tested.  Before we were running the tests on the
editable clone of the lasio repo.
@kinverarity1
Copy link
Owner

Thanks, looks good

@kinverarity1 kinverarity1 merged commit 27099d3 into kinverarity1:gh-ci-changes-1 Sep 14, 2020
@dcslagel dcslagel deleted the wheel-ci-config branch December 22, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants