Read data section as dataframe #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 20, 2021 16:20
|
Note to myself: Failing for pandas 0.25.3 - the other tests are using pandas >= 1. |
|
Also, I guess for wrapped files now we can attempt to convert each curve to a float dtype after the reader is finished. This will be the way we do it anyway for LAS 3 where the data types are specified. |
9 tasks
kinverarity1
added
the
data-section-parser
|
Closing this - based on our work in #452 it's clear that the |
|
See #461 for the solution to this. No record array, just only ever passing around 1D ndarrays for curves instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new function to reader.py and makes necessary changes in LASFile so that a data section can be read as a pandas DataFrame. The benefit of this is that now data section columns (== curves) can have different data types, at least when reading unwrapped files. This is happening already such that if items cannot be coerced to floating point numbers, that curve will have a pandas
objectdata type i.e. strings.All tests are passing and apart from the new function in reader.py (read_data_section_into_dataframe) there are no changes to internal function arguments etc.