Reshape data array inside data section reader function #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two things:
(1) the argument `n_columns` to the function signature
for read_data_section_iterative (i.e. the normal data section reader)
function.
(2) code to (attempt) to re-shape the numpy array read by the
data section reader into a 2D array.
If the file is wrapped and therefore the number of columns is unclear
(i.e. inspect_data_section() returns -1), then the data section
reader code does not currently attempt to reshape the file.
The reason for this is so that the data section reader function
can be further modified to return a 2D numpy record array with
different dtypes per column.
kinverarity1
added
the
data-section-parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two things:
the argument
n_columnsto the function signature for read_data_section_iterative (i.e. the normal data section reader) function.code to (attempt) to re-shape the numpy array read by the data section reader into a 2D array.
If the file is wrapped and therefore the number of columns is unclear (i.e.
inspect_data_section()returns -1), then the data section reader code does not currently attempt to reshape the array.The reason for this is so that the data section reader function can be further modified to return a 2D numpy record array with different dtypes per column.