Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Add error handling to utility functions, remove assumptions about host #301

Merged
merged 1 commit into from
Aug 22, 2018

Commits on Aug 20, 2018

  1. Add error handling to utility functions, remove assumptions about hos…

    …t path.
    
    Most error checking was missing from pkg/bootstrap/node.go.
    Added to all utility functions.
    
    In addition, pkg/bootstrap/node.go made assumptions about
    host-path for binaries (machinectl/qemu-img/mount etc). Remove this.
    If the binaries are not on the PATH, fail. This is the reason
    for Unix PATH, to indicate where to find executables, hard-coding
    fallbacks can create a security issue or astonishment.
    
    The code had a hard-coded assumption that the machine had
    selinux available (e.g. it assumped selinux is enforcing/not-enforcing)
    where there is a 3rd-option (not available). If selinux is not
    available (e.g. Ubuntu-derived hosts), then return false
    from isSELinuxEnforcing().
    donbowman committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    7fabf4d View commit details
    Browse the repository at this point in the history