This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Add cpu_manager_policy to workers #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knrt10
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
c7db768
to
e0de8f7
Compare
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
e0de8f7
to
6f1abaa
Compare
surajssd
changed the title
|
I was adding this feature to baremetal and was wondering how to restrict this to certain workers since there are no worker pools for it as of now. WDYT if I skip adding support to baremetal? |
invidian
reviewed
Jul 22, 2021
assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/variables.tf
Outdated
Show resolved
Hide resolved
assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/variables.tf
Outdated
Show resolved
Hide resolved
assets/terraform-modules/packet/flatcar-linux/kubernetes/workers/variables.tf
Outdated
Show resolved
Hide resolved
Lack of worker pools on Bare metal (actually Matchbox) seems like ongoing issue with feature parity. |
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
6f1abaa
to
2738400
Compare
invidian
reviewed
Jul 28, 2021
invidian
reviewed
Aug 5, 2021
|
@invidian one more round of review? |
|
@surajssd I already left some comments, I don't see any replies or new code to review. Also, PR has conflicts which must be resolved. |
My bad, I had this page open for many days and did not see those comments. |
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
2738400
to
b6b3120
Compare
invidian
reviewed
Aug 6, 2021
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
b6b3120
to
c26fc73
Compare
invidian
reviewed
Aug 18, 2021
assets/terraform-modules/aws/flatcar-linux/kubernetes/workers/variables.tf
Outdated
Show resolved
Hide resolved
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
c26fc73
to
8e9d3bb
Compare
invidian
reviewed
Aug 24, 2021
assets/terraform-modules/aws/flatcar-linux/kubernetes/workers/variables.tf
Outdated
Show resolved
Hide resolved
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
8e9d3bb
to
6d4e20d
Compare
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This allows a user to choose the cpu manager policy on a worker pool. Possible values are: `none` and `static`. To make this work, kubelet also needs a static allocation of system reserved and kubernetes reserved CPUs to be defined. So this commit also adds the default of 300m cores for kube-reserved-cpu and 1500m cores for system-reserved-cpu when `cpu_manager_policy` is set. closes: #1337 Signed-off-by: knrt10 <kautilya@kinvolk.io> Co-authored-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
6d4e20d
to
3897bda
Compare
invidian
previously approved these changes
Sep 2, 2021
assets/terraform-modules/aws/flatcar-linux/kubernetes/workers/variables.tf
Outdated
Show resolved
Hide resolved
This allows a user to choose the cpu manager policy on a worker pool. Possible values are: `none` and `static`. To make this work, kubelet also needs a static allocation of system reserved and kubernetes reserved CPUs to be defined. So this commit also adds the default of 300m cores for kube-reserved-cpu and 1500m cores for system-reserved-cpu when `cpu_manager_policy` is set. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
knrt10/cpu-pinnig-worker-pool
branch
from
3897bda
to
6819bdc
Compare
invidian
approved these changes
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add flag to worker pools also added a knob for the user to configure
it.
closes: #1337
Signed-off-by: knrt10 kautilya@kinvolk.io