This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
baremetal: configure and persist kernel args #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the kernel arguments can be set for PXE, they have not been applied to the final installation. Use the /usr/share/oem/grub.cfg file to permanently set the kernel arguments, so that on each boot the final installation uses the kernel arguments provided by the user.
The kernel console setting was hardcoded and only used for PXE boots. Make the setting a variable and also apply it for the final installation.
ipochi
suggested changes
Jun 16, 2021
ipochi
reviewed
Jun 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel console setting was hardcoded and only used for PXE boots.
Make the setting a variable and also apply it for the final
installation.
While the kernel arguments can be set for PXE, they have not been
applied to the final installation.
Use the /usr/share/oem/grub.cfg file to permanently set the kernel
arguments, so that on each boot the final installation uses the
kernel arguments provided by the user.