This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
baremetal: let installer.service retry on failure #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pothos Please rebase, that should fix the tinkerbell CI (fix was merged) |
pothos
force-pushed
the
kai/installer-retry
branch
from
7e99e7f
to
5d74929
Compare
In case the network only has a temporary problem, the installer service should start again on failure. Convert it to a oneshot service to set RemainAfterExist, so that it is not triggered twice if anything that depends on it is pulling it in again after it finished.
pothos
force-pushed
the
kai/installer-retry
branch
from
5d74929
to
1a346e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the network only has a temporary problem, the installer service
should start again on failure.
Convert it to a oneshot service to set RemainAfterExist, so that it is
not triggered twice if anything that depends on it is pulling it in
again after it finished.