This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
cluster/apply: honor --upgrade-kubelets #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
commented
Jun 28, 2021
invidian
reviewed
Jun 28, 2021
iaguis
force-pushed
the
iaguis/honor-upgrade-kubelets
branch
from
6887236
to
367146d
Compare
invidian
previously approved these changes
Jun 28, 2021
surajssd
previously approved these changes
Jun 29, 2021
It was being ignored and kubelets were being upgraded no matter what.
iaguis
force-pushed
the
iaguis/honor-upgrade-kubelets
branch
from
367146d
to
5e4e3b2
Compare
invidian
approved these changes
Jul 1, 2021
|
The only change from last reviews is a rebase so I'll merge this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was being ignored and kubelets were being upgraded no matter what.
Fixes #1480