This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
feat: define MaxHistory for Helm releases #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
niels/cleanup_helm_history
branch
from
179806e
to
e1d268a
Compare
Defining the `MaxHistory` option during the rollback Helm action so that the releases history is cleaned up accordingly. Without this option the history would never been cleared which is accumulating old configuration which can be harmful when a incorrect rollback is applied. By cleaning up the history, we limit the potential impact rolling back to a older version.
surajssd
force-pushed
the
niels/cleanup_helm_history
branch
from
e1d268a
to
a0b59a4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining the
MaxHistoryoption during the rollback Helm action so thatthe releases history is cleaned up accordingly.
Without this option the history would never been cleared which is
accumulating old configuration which can be harmful when a incorrect
rollback is applied. By cleaning up the history, we limit the potential
impact rolling back to a older version.