This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
pkg/components/util: use Helm post-renderer instead of Manifests field #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
invidian/dont-use-custom-helm-manifests-field
branch
2 times, most recently
from
8035b0e
to
498d85c
Compare
|
Unfortunately, I'm not sure why this fails 😞 |
invidian
force-pushed
the
invidian/dont-use-custom-helm-manifests-field
branch
from
498d85c
to
d93192b
Compare
invidian
force-pushed
the
invidian/dont-use-custom-helm-manifests-field
branch
3 times, most recently
from
8f3b4fc
to
a182195
Compare
As Manifests filed in Chart object is a custom field, added to our fork of Helm. Now Helm offers post-renderer feature, which allows to further customize the manfiests after Helm's templating engine and before the installation of the manifests. This allows us to use post-renderer feature and drop one of maintained custom patches, which means less maintenance for us. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/dont-use-custom-helm-manifests-field
branch
from
a182195
to
1ee6455
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Manifests filed in Chart object is a custom field, added to our fork
of Helm. Now Helm offers post-renderer feature, which allows to further
customize the manfiests after Helm's templating engine and before the
installation of the manifests.
This allows us to use post-renderer feature and drop one of maintained
custom patches, which means less maintenance for us.
See helm/helm#8497 (comment) for motivation.
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io