Make Money.to_string! actually raise if there is an error

[rodrigues]

Hi @kipcole9, I was reading the code and found that to_string! doesn't fail in case to_string returns an error tuple. Instead, it just returns the error tuple.

Wrote a test that confirmed that, and made to_string! raise Cldr exceptions.

However, I couldn't write a test that reaches the more generic clause, as I don't know if it can return an error different than {:error, {cldr_error_type, message}}.

[kipcole9]

@rodrigues Thanks very much for the report and PR.

I've manually merged the code and tests with just a slight modification since I can confirm that the error return for to_string/2 is {:error, {atom, String.t}}.

I have one dialyzer issue on the spec that is puzzling (overlapping contract) but the I've pushed this commit to master branch of the repo.

I'll publish a new release to hex when I resolve the dialyzer issue.

[kipcole9]

Fixed the dialyzer error and published version 3.4.3 to hex.

Many thanks again.

[rodrigues]

Thanks @kipcole9 !

FYI, I discovered this while investigating this other issue: https://elixirforum.com/t/excruciatingly-slow-performance-of-ex-money-money-to-string/22876

[kipcole9]

Fixed the performance issue in ex_cldr with version 2.7.1

Really appreciate the assistance, thanks.