Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] EEP.xml: F6-05-01 #38

Merged
merged 2 commits into from
May 18, 2016
Merged

[add] EEP.xml: F6-05-01 #38

merged 2 commits into from
May 18, 2016

Conversation

zpfvo
Copy link
Contributor

@zpfvo zpfvo commented May 11, 2016

Added the water leakage sensor to EEP.xml
I tested with Afriso Watersensor ECO
The profile is a bit strange, since the enum only defines one state (0x11) i don't know if i did this right.

@coveralls
Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 91.727% when pulling 0825367 on zpfvo:master into 5e435ea on kipe:master.

@kipe
Copy link
Owner

kipe commented May 14, 2016

Thanks, looks great 👍
I'd assume that the data is 0 otherwise, so using rangeitem might be an option? Something like:

<enum description="Water Sensor" shortcut="WAS" offset="0" size="8">
    <rangeitem description="Water not detected" start="0" end="16" />
    <item description="Water detected" value="17" />
    <rangeitem description="Water not detected" start="18" end="255" />
</enum>

This way, a clear message of water not being detected would also be visible?

@zpfvo
Copy link
Contributor Author

zpfvo commented May 17, 2016

I think there will never be another message than 'water detected' since the device needs the water to send a message in the first place. It uses the swelling of cork rings in water to harvest mechanical energy for the telegram. The only thing that changes is the Energy Bow when the cork rings dry up again and the handle snaps back in its initial position.
Any other message is not specified.
I don't know how to handle this. Maybe a 'don't care' or even 'error' might be more appropriate.
Edit: or simply 'not specified' ?

@kipe
Copy link
Owner

kipe commented May 17, 2016

Hmm...

WaterSensor Eco sends a radio signal when the fibre disks expand (wet) and a radio signal. when the fibre disks shrink to their normal size (dry) again.

So I think there should be another message, weird that it's not defined in the EEP. rangeitem with "not specified" might be the way to go here...

@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage remained the same at 91.727% when pulling 6156c5e on zpfvo:master into 5e435ea on kipe:master.

@kipe kipe merged commit 753fa37 into kipe:master May 18, 2016
@kipe
Copy link
Owner

kipe commented May 18, 2016

Great, thanks :)

douwevandermeij pushed a commit to douwevandermeij/enocean that referenced this pull request Oct 26, 2017
* kipe/master: (156 commits)
  Bump version to v0.40. (kipe#60)
  [add] a5-04-01 Temperature and Humidity Sensor (kipe#59)
  [fix] a5-10-12 scale was inversed (kipe#58)
  [add] a5-38-08 Gatway dimming command (kipe#56)
  Support command for any rorg (kipe#55)
  [add] a5-10-12 Temperature and Humidity Sensor and Set Point (kipe#54)
  Added Equipment Profile (EEP), A5-14-01 (4BS) (kipe#48)
  [add] EEP A5-30-03 (kipe#46)
  [add] EEP A5-08-01 Light, Temperature and Occupancy Sensor (kipe#45)
  [fix] correct scale for a5-10-03 room operating panel (kipe#43)
  Add .venv to .gitignore.
  Update SUPPORTED_PROFILES.md. Closes issue kipe#40.
  [add] EEP.xml: Mechanical Window handle (F6-10-00) (kipe#41)
  broken link (kipe#39)
  [add] EEP.xml: F6-05-01 (kipe#38)
  Minor fixes.
  Update EEP.xml
  update logger message
  Use floats for value scale and range in generate_supported_profiles.py
  Update SUPPORTED_PROFILES.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants