Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] EEP.xml: Mechanical Window handle (F6-10-00) #41

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

zpfvo
Copy link
Contributor

@zpfvo zpfvo commented May 31, 2016

Added the Hoppe mechanical window handle to the EEP.xml
I tried to follow the EEP (2.6.4) as good as possible. But this profile was rather strange. (it even has a typo in it. First entry should be 'Moved from up to right')
I don't kow if you are happy with the long description strings. If i had designed this profile it would just have 3 states:

  • top
  • vertical
  • down

But Hoppe somehow decided to more describe the movement of the handle than the state.

Tested with Hoppe SecuSignal handle

@coveralls
Copy link

coveralls commented May 31, 2016

Coverage Status

Coverage remained the same at 91.727% when pulling dfc1547 on zpfvo:add-window-handle into da71b6a on kipe:master.

@kipe
Copy link
Owner

kipe commented May 31, 2016

Hmm, those states do indeed seem to be enough, as the codes only change according to the end position. I'll double-check later and merge, if all seems correct.

@kipe
Copy link
Owner

kipe commented Oct 17, 2016

... If I remember correctly, these states were enough (as I remember double-checking them and I would have posted if they weren't).
-> Merging. Once again, thanks for your work 👍

@kipe kipe merged commit 6d9403c into kipe:master Oct 17, 2016
douwevandermeij pushed a commit to douwevandermeij/enocean that referenced this pull request Oct 26, 2017
* kipe/master: (156 commits)
  Bump version to v0.40. (kipe#60)
  [add] a5-04-01 Temperature and Humidity Sensor (kipe#59)
  [fix] a5-10-12 scale was inversed (kipe#58)
  [add] a5-38-08 Gatway dimming command (kipe#56)
  Support command for any rorg (kipe#55)
  [add] a5-10-12 Temperature and Humidity Sensor and Set Point (kipe#54)
  Added Equipment Profile (EEP), A5-14-01 (4BS) (kipe#48)
  [add] EEP A5-30-03 (kipe#46)
  [add] EEP A5-08-01 Light, Temperature and Occupancy Sensor (kipe#45)
  [fix] correct scale for a5-10-03 room operating panel (kipe#43)
  Add .venv to .gitignore.
  Update SUPPORTED_PROFILES.md. Closes issue kipe#40.
  [add] EEP.xml: Mechanical Window handle (F6-10-00) (kipe#41)
  broken link (kipe#39)
  [add] EEP.xml: F6-05-01 (kipe#38)
  Minor fixes.
  Update EEP.xml
  update logger message
  Use floats for value scale and range in generate_supported_profiles.py
  Update SUPPORTED_PROFILES.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants